-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set transaction TTL based on time with shelly date fallback #286
Conversation
Tried building, but when I start the stack again, I’m getting this error:
I haven’t changed anything else. It was a preview instance, fully synced. I just checked out to the PR, built it, and put it up. |
7b9e992
to
109ec9c
Compare
The issue you are facing is unrelated to the PR itself. |
355f64c
to
191a75d
Compare
941a551
to
f96c634
Compare
5cead0c
to
d14b2a6
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good!
Except the sonar issues, but it marked the same like I did. Autowire, unused imports and a public modifier in a test class. So just minor stuff.
@@ -29,6 +31,7 @@ | |||
"org.cardanofoundation.rosetta.api.common.model.entity"}) | |||
@OpenAPIDefinition(info = @Info(title = "APIs", version = "1.0", description = "Rosetta APIs v1.0")) | |||
@EnableScheduling | |||
@Slf4j |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed here.
@Slf4j | ||
public class OfflineSlotServiceImpl implements OfflineSlotService { | ||
|
||
@Autowired |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do use Autowire here and not constructor injection?
protected CardanoConverters cardanoConverters; | ||
|
||
@Override | ||
public long getCurrentSlotBasedOnTime() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice solution to estimate the solution. I like it!
d6bf005
to
38e5a6d
Compare
c5c9067
to
bc5de7a
Compare
bc5de7a
to
ddaef4f
Compare
No description provided.