Make Optional support specializing its representation. #6058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
force-pushed
the
optional-storage-customization
branch
from
383c09a to
4fe2900
Compare
zygoloid
force-pushed
the
optional-storage-customization
branch
from
4fe2900 to
d57eedb
Compare
Use a pair of `MaybeUnformed(T)` and `bool` by default. When `T` is a pointer type, store just a `MaybeUnformed(T*)`, and use its unformed null state for an absent pointer value.
zygoloid
force-pushed
the
optional-storage-customization
branch
from
d57eedb to
6320c00
Compare
josh11b
approved these changes
Oct 14, 2025
dwblaikie
approved these changes
Oct 15, 2025
Merged
via the queue into
carbon-language:trunk
with commit Oct 15, 2025
851da43
15 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using a pair of
MaybeUnformed(T)and aboolas the normal representation forOptional(T). WhenTis a pointer type, add a customized representation that usesMaybeUnformed(T*), with a null representation used for absent values.