-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(unordered-list): add support for marker types #20871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(unordered-list): add support for marker types #20871
Conversation
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #20871 +/- ##
==========================================
- Coverage 92.45% 85.56% -6.89%
==========================================
Files 515 357 -158
Lines 37601 14503 -23098
Branches 5780 4900 -880
==========================================
- Hits 34764 12410 -22354
+ Misses 2688 1954 -734
+ Partials 149 139 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aaac6a4 to
ecee293
Compare
bb11cd2 to
428b1db
Compare
Description
Add support for different list marker types (disc, circle, square, hyphen, custom) to the UnorderedList component in both React and Web Components packages.
This change allows users to customize list markers beyond the default hyphen (top-level) and square (nested) styles. The implementation uses native CSS
list-style-typefor disc/circle/square markers and custom::beforepseudo-elements for hyphen and custom markers.Issue
Closes #16937
Changes Made
Features
typeprop accepting:'disc' | 'circle' | 'square' | 'hyphen' | 'custom'customMarkerprop for custom marker content (requirestype="custom")React Component
typeandcustomMarkerprops toUnorderedListPropsinterfacetypepropWeb Components
typeandcustomMarkerproperties with attribute reflectiontypewhen not specified)SCSS Changes
.cds--list--marker-{type}list-style-typesupport for disc/circle/square--cds--list--marker-contentExamples
React
Web Components
Marker Types Reference
disccirclesquarehyphencustomTesting
Checklist