chore: add wildcard to globals export #20866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20866 +/- ##
==========================================
+ Coverage 85.53% 92.39% +6.86%
==========================================
Files 357 511 +154
Lines 14475 37352 +22877
Branches 4818 5741 +923
==========================================
+ Hits 12381 34511 +22130
- Misses 1956 2693 +737
- Partials 138 148 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kennylam
approved these changes
Nov 3, 2025
Gururajj77
approved these changes
Nov 5, 2025
alisonjoseph
approved these changes
Nov 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Nov 10, 2025
c99c31c
41 of 43 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into issues around pulling in the
icon-loader.jsfrom theglobals/internalfolder and our application complains that it's not able to find the export. Adding the wildcard to thees/globalsexport field in the @carbon/web-components package.json - aligning with thees/componentsexport, fixes this issue for us.Changelog
Changed
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)[ ] Tested for cross-browser consistency[ ] Validated that this code is ready for review and status checks should passMore details can be found in the pull request guide