Skip to content

Conversation

@naaa760
Copy link
Contributor

@naaa760 naaa760 commented Nov 3, 2025

Closes #20842

Changelog

Changed

  • Fixed keyboard typing detection logic in Dropdown component

Testing / Reviewing

  1. Test arrow key navigation doesn't trigger typing mode
  2. Verify Space/Enter open dropdown correctly
  3. Test typing letters enters typing mode with proper timer reset

PR Checklist

  • Reviewed every line of the diff
  • Addressed any impact on accessibility (a11y)

@naaa760 naaa760 requested a review from a team as a code owner November 3, 2025 10:15
@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a31e736
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6924df7089026400085a9550
😎 Deploy Preview https://deploy-preview-20860--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a31e736
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6924df703cd79e000730ab9a
😎 Deploy Preview https://deploy-preview-20860--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.58%. Comparing base (b486103) to head (a31e736).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20860      +/-   ##
==========================================
- Coverage   92.62%   92.58%   -0.04%     
==========================================
  Files         515      515              
  Lines       38222    38224       +2     
  Branches     5861     5802      -59     
==========================================
- Hits        35403    35391      -12     
- Misses       2669     2684      +15     
+ Partials      150      149       -1     
Flag Coverage Δ
main-packages 85.57% <100.00%> (-0.04%) ⬇️
web-components 96.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a31e736
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6924df70faee2600084e6293
😎 Deploy Preview https://deploy-preview-20860--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dropdown] Audit: Dropdown component

3 participants