-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(pagination): tooltip visibility #20850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pagination): tooltip visibility #20850
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20850 +/- ##
==========================================
- Coverage 92.35% 92.33% -0.03%
==========================================
Files 511 511
Lines 37341 37341
Branches 5728 5728
==========================================
- Hits 34487 34478 -9
- Misses 2706 2715 +9
Partials 148 148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tay1orjones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
- Wrote passing tests that cover this change
Not required but if you wanted to cover this you could add a vrt test that hovers/focuses the button before calling snapshotStory
|
@tay1orjones |
7efc295
|
Hey there! v11.95.0 was just released that references this issue/PR. |
Closes #20844
Fixes a bug with the pagination component where the tooltip would not appear on hover
Changelog
New
Changed
overflow: initialstyle out of the container query and removed theoverflow-xstyleTesting / Reviewing
forwardTextandbackwardTextshould always show on hover, regardless of the viewport/container sizePR Checklist
As the author of this PR, before marking ready for review, confirm you: