Skip to content

Conversation

@maradwan26
Copy link
Contributor

@maradwan26 maradwan26 commented Oct 31, 2025

Closes #20844

Fixes a bug with the pagination component where the tooltip would not appear on hover

Changelog

New

  • Added a top margin to all of the pagination stories since the tooltips where overflowing out of the page
  • Added vrt tests to cover this change

Changed

  • Moved overflow: initial style out of the container query and removed the overflow-x style

Testing / Reviewing

  • Go to the Pagination stories in the React deploy preview
  • The tooltips for forwardText and backwardText should always show on hover, regardless of the viewport/container size
  • This should not cause any breaking changes to the other pagination styles
  • There should be new snapshots in percy from the new vrt test

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

@maradwan26 maradwan26 requested a review from a team as a code owner October 31, 2025 15:22
@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 3bc5c2d
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/690a31d069e57e00085e1188
😎 Deploy Preview https://deploy-preview-20850--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3bc5c2d
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/690a31d0671cc600087c6ab9
😎 Deploy Preview https://deploy-preview-20850--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3bc5c2d
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/690a31d040b8b200089f04f3
😎 Deploy Preview https://deploy-preview-20850--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (ef18b63) to head (3bc5c2d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20850      +/-   ##
==========================================
- Coverage   92.35%   92.33%   -0.03%     
==========================================
  Files         511      511              
  Lines       37341    37341              
  Branches     5728     5728              
==========================================
- Hits        34487    34478       -9     
- Misses       2706     2715       +9     
  Partials      148      148              
Flag Coverage Δ
main-packages 85.49% <ø> (ø)
web-components 96.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • Wrote passing tests that cover this change

Not required but if you wanted to cover this you could add a vrt test that hovers/focuses the button before calling snapshotStory

@maradwan26
Copy link
Contributor Author

@tay1orjones
Thanks! I added a vrt test

@alisonjoseph alisonjoseph added this pull request to the merge queue Nov 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 3, 2025
@maradwan26 maradwan26 enabled auto-merge November 4, 2025 17:03
@maradwan26 maradwan26 added this pull request to the merge queue Nov 4, 2025
Merged via the queue into carbon-design-system:main with commit 7efc295 Nov 4, 2025
91 of 100 checks passed
@maradwan26 maradwan26 deleted the pagination-tooltip-fix branch November 4, 2025 19:26
@carbon-automation
Copy link
Contributor

Hey there! v11.95.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Pagination tooltip does not show up

4 participants