fix: remove click handler for the anchorlink when useRouter is true #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Licen-it
reviewed
Jun 5, 2024
| [fragment]="routeExtras?.fragment" | ||
| [queryParamsHandling]="routeExtras?.queryParamsHandling" | ||
| [preserveFragment]="routeExtras?.preserveFragment" | ||
| [onSameUrlNavigation]="routeExtras?.onSameUrlNavigation" |
There was a problem hiding this comment.
onSameUrlNavigation is the only one that is not defined by the routerLink directive...it seems to be a property only for router.navigate which is overriding the default configuration for the router
klaascuvelier
force-pushed
the
fix-2911-userouter-sidenav
branch
from
addbac2 to
7085c56
Compare
Akshat55
requested changes
Jun 12, 2024
Licen-it
approved these changes
Jun 13, 2024
Akshat55
approved these changes
Jun 13, 2024
Akshat55
changed the title
|
🎉 This PR is included in version 5.27.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2911
Removes the click handler for the element when using
useRouter. Adds in all available routeExtras so they get passed along.