fix: Allow users to pass in templates in tabs to allow onDestroy hook to be called for content #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be called for content Signed-off-by: Akshat Patel <[email protected]>
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Akshat Patel <[email protected]>
Signed-off-by: Akshat Patel <[email protected]>
|
DCO Assistant Lite bot All contributors have signed the DCO. |
…e time Signed-off-by: Akshat Patel <[email protected]>
Signed-off-by: Akshat Patel <[email protected]>
Akshat55
force-pushed
the
tab-template-projection
branch
from
84b5575 to
6c7f311
Compare
Signed-off-by: Akshat Patel <[email protected]>
zvonimirfras
approved these changes
Jun 4, 2024
|
🎉 This PR is included in version 5.26.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2908
Angular keeps track of projected content even if it is conditionally hidden in component it is passed in. This means the life cycle hooks are only called once instead of every time *ngIf condition is set to true within the projecting component.
Changelog
New