Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy inner text or text content of code element #2875

Merged
merged 3 commits into from
May 9, 2024

Conversation

Akshat55
Copy link
Contributor

@Akshat55 Akshat55 commented May 8, 2024

Issue went unnoticed due to storybook creating code argument in global scope which was accessible by the component.

Changelog

Changed

  • Now text content is correctly copied to clipboard from code element
  • MISC: Docs now use different variable name than the one used in component to avoid referencing value in global scope.

@Akshat55 Akshat55 requested a review from a team as a code owner May 8, 2024 22:51
Copy link

netlify bot commented May 8, 2024

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 8032db3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/663cf950bdb2c900087913fb
😎 Deploy Preview https://deploy-preview-2875--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akshat55
Copy link
Contributor Author

Akshat55 commented May 9, 2024

We cannot write tests for this since we run into issues related to permissions, (Write permission denied.). I'm assuming this is why there was no test case for this, Couldn't find any information on how to override this.

@zvonimirfras zvonimirfras merged commit f114db5 into carbon-design-system:master May 9, 2024
13 checks passed
Copy link

github-actions bot commented May 9, 2024

🎉 This PR is included in version 5.25.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Akshat55 Akshat55 deleted the snippet-fix branch May 9, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants