fix: hide placeholder, label, and helper text when skeleton is enabled #2748
Conversation
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Also, when skeleton is true, could you hide the label and helper text? This would match the react behavior:
https://react.carbondesignsystem.com/?path=/story/components-dropdown--skeleton
Should require updating the ngIf condition for both.
Sure, I can do the changes. Since there are no issues raised.. How do you want me to proceed ? |
|
No you can make the changes in this PR since they are related to dropdown skeleton. 😄 |
commiting this part of code as per suggestion Co-authored-by: Akshat Patel <[email protected]>
There was a problem hiding this comment.
@abiramcodes Test passes, not sure why it isn't passing locally for you.
Seems good so far, all you need is to update the NgIf for the label and helperText to not display when skeleton is enabled!
Akshat55
changed the title
|
@abiramcodes We have quite a few other components where we have skeleton issues, would you like to contribute to those as well? 😄 |
…s enabled (carbon-design-system#2748)" This reverts commit ebb57a9.
Great!!! , Thanks |
|
🎉 This PR is included in version 5.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #2715
When the skeleton is set as
true, placeholder is made asempty.Changelog
Changed
Assigned the placeholder value as
testto pass thenpm test.