Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close datepicker on escape key press #2741

Merged

Conversation

abiramcodes
Copy link
Contributor

Closes #2739

The issue has been fixed and onclick of the escape key , the data-picker-single + date-picker-range will be closed

Changelog

New

  • Closed the date-picker-single and range when the escape key is clicked

@abiramcodes abiramcodes requested a review from a team as a code owner December 7, 2023 19:39
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit aa609c8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/65972a2ad761e40008c54c49
😎 Deploy Preview https://deploy-preview-2741--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abiramcodes abiramcodes changed the title Fixed the close of the date-picker on click of escape key Fixed the close of the date-picker on click of escape key #2739 Dec 7, 2023
@Akshat55 Akshat55 changed the title Fixed the close of the date-picker on click of escape key #2739 fix: close datepicker on escape key press Jan 4, 2024
@zvonimirfras zvonimirfras merged commit 5c29c1f into carbon-design-system:master Jan 4, 2024
13 checks passed
Copy link

github-actions bot commented Jan 5, 2024

🎉 This PR is included in version 5.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date Picker is not closing on escape
3 participants