Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #2715 #2740

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

abiramcodes
Copy link
Contributor

Closes #2715

The place holder has been removed if the skeleton state is set to true.

Changelog

Screenshot 2023-12-08 000832

New

  • Hides the placeholder of the multi-select dropdown if the it is in the skeleton state.

@abiramcodes abiramcodes requested a review from a team as a code owner December 7, 2023 19:00
Copy link

github-actions bot commented Dec 7, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 7b89f1d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/6572164ffc62a700085a4a49
😎 Deploy Preview https://deploy-preview-2740--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abiramcodes
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@abiramcodes
Copy link
Contributor Author

recheck

@zvonimirfras zvonimirfras merged commit 7b89f1d into carbon-design-system:master Jan 4, 2024
12 checks passed
@Akshat55
Copy link
Contributor

Akshat55 commented Jan 4, 2024

@abiramcodes, you made two PRs from the same branch... we merged your datepicker branch which marked this as merged as well somehow.

The solution you have provided could be a lot better, could you please create another PR. I also recommend that you do not use master branch for making PRs.

@abiramcodes
Copy link
Contributor Author

@Akshat55, glad that my PR has been merged for the date-picker part
Of course, I will raise another PR. Thanks for your inputs on the branch part, will follow it!.

Copy link

github-actions bot commented Jan 5, 2024

🎉 This PR is included in version 5.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi Dropdown skeleton states is not enabled
3 participants