Fix CI: TypeScript error in Webamp renderInto call #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add non-null assertion operator to ref.current when calling webamp.renderInto() to match the pattern used elsewhere in the component and resolve the CI type error: "Argument of type 'HTMLDivElement | null' is not assignable to parameter of type 'HTMLElement'" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
✅ Deploy Preview for tourmaline-kringle-c98715 canceled.
|
|
Size Change: 0 B 🆕 Total Size: 0 B |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ref.currentwhen callingwebamp.renderInto()Root Cause
The new Webamp
renderIntoAPI expects a non-nullHTMLElementparameter, butref.currenthas typeHTMLDivElement | null. The TypeScript compiler was correctly flagging this as a potential runtime error.Changes Made
packages/skin-database/app/(modern)/scroll/Webamp.tsxline 45!) to match the pattern used elsewhere in the component (lines 46, 51)Test Plan
pnpm run type-check)pnpm run lint)pnpm run build)🤖 Generated with Claude Code