Skip to content

Remove legacy JS files from winamp-eqf package#1327

Merged
captbaritone merged 1 commit intomasterfrom
remove-legacy-winamp-eqf-js-files
Nov 28, 2025
Merged

Remove legacy JS files from winamp-eqf package#1327
captbaritone merged 1 commit intomasterfrom
remove-legacy-winamp-eqf-js-files

Conversation

@captbaritone
Copy link
Owner

Summary

These files were duplicates of the TypeScript source files in src/.

Problem

Running pnpm run lint from the monorepo root was failing with errors in:

  • packages/winamp-eqf/constants.js
  • packages/winamp-eqf/creator.js
  • packages/winamp-eqf/index.js
  • packages/winamp-eqf/parser.js

However, CI was passing because it runs turbo lint, which uses each package's own lint script. The winamp-eqf package's lint script only lints src/, not the root-level .js files.

Solution

Delete the legacy .js files. The package builds from src/*.ts to built/*.js, so these root-level files were unused.

Testing

  • pnpm run lint passes
  • pnpm run test --filter winamp-eqf passes (25 tests)
  • pnpm run build in winamp-eqf succeeds

These files were duplicates of the TypeScript source files in src/.
The package builds from src/*.ts to built/*.js, so these root-level
.js files were unused and causing lint failures when running
`pnpm run lint` from the monorepo root.
@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for tourmaline-kringle-c98715 canceled.

Name Link
🔨 Latest commit 9113d29
🔍 Latest deploy log https://app.netlify.com/projects/tourmaline-kringle-c98715/deploys/6929fa70051c0d0008b9a28d

@github-actions
Copy link

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@captbaritone captbaritone merged commit 8fa7701 into master Nov 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant