Repository navigation
x86: decode reserved x87 register aliases - #3141
Merged
Rot127 merged 3 commits intoNov 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3141 +/- ##
=======================================
Coverage ? 61.45%
=======================================
Files ? 243
Lines ? 56825
Branches ? 10081
=======================================
Hits ? 34921
Misses ? 16708
Partials ? 5196 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rot127
requested changes
Oct 30, 2026
Rot127
requested changes
Nov 2, 2026
Collaborator
There was a problem hiding this comment.
Correct me if mistake, but the tests seem to have a lot of duplicates in it.
Please minimize them.
Contributor
Author
There was a problem hiding this comment.
yeah, i copied them, don't even know why:) changed
Rot127
approved these changes
Nov 4, 2026
Collaborator
|
Redness unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Decode reserved x87 register aliases for fcom, fcomp and fxch using the existing instruction tables. Preserve the original opcode and ModRM.
Test plan
Added five regression cases covering 16/32/64 bit modes, prefixes, att syntax, encoding details and invalid neighboring encodings.
Closing issues
Closes #3117