feat: show current liquidation price alongside new price in margin modal (fixes #4)#204
Open
jiangyj545 wants to merge 1 commit into
Open
feat: show current liquidation price alongside new price in margin modal (fixes #4)#204jiangyj545 wants to merge 1 commit into
jiangyj545 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4: Show both current and new liquidation prices in the Add/Remove Margin modal.
Problem
The Edit Margin modal only showed the "New Liq. Price" after entering a margin amount. Users could not easily compare the current vs new liquidation price.
Solution
Added a "Current Liq. Price" row above the existing "New Liq. Price" row, displaying
data.position.liqprice(the position's current liquidation price). This gives users full clarity on how their margin change affects liquidation risk.Changes
src/components/modals/EditMargin.svelteLabelValuerow showing current liq price (data.position.liqprice)npx rollup -c✅Screenshot (before/after)
Before: Only "New Liq. Price" shown
After: Both "Current Liq. Price" and "New Liq. Price" shown for easy comparison