-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest changes on develop to main #245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. Update other test files to kick off tests
…aging the max-length attribute
…components Add maxlength on input components
…-hover-state Add css variables to components
Merge pull request #238 from capitec/develop
BOTLANNER
approved these changes
Oct 3, 2024
stefan505
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pull request to merge latest change from develop to main before a release the changes included are
Expose a css variable that allows users to set the hover color of the internal input element when hovering for a autocomplete option on the following components.
Add a max-length attribute to the following input components
omni-email-field
omni-number-field
omni-password-field
omni-search-field
omni-text-field
Added blur on enter for the Search Field component.
Added css variable to Modal component to apply a min width.
Resolved bug of search field of Select component does not clear when the dialog is closed on the mobile implementation.
Screenshots (if appropriate):
All Submissions:
Changes to Core Features: