Fix Requirements to match dataprofiler - scipy>=1.10.0 #342
Conversation
|
@taylorfturner I was not able to understand the error - Do you know what I missed here .
|
pre-commit wasn't run locally prior to the commit @rxm7706 |
Head branch was pushed to by a user without write access
taylorfturner
requested review from
tazitoo and
taylorfturner
and removed request for
tazitoo
@taylorfturner Thank you ! please review - updated branch. |
| numpy>=1.22.0 | ||
| scikit-learn>=1.1.0 | ||
| scipy==1.8.0 | ||
| dataprofiler>=0.8.8 | ||
| scipy>=1.10.0 |
There was a problem hiding this comment.
looks good to me -- were these causing particular issues?
| @@ -25,7 +25,7 @@ def parse_requirements(filename): | |||
| return [line for line in lineiter if line and not line.startswith("#")] | |||
|
|
|||
|
|
|||
| with open("README.md") as readme: | |||
| with open("README.md", encoding="utf8") as readme: | |||
There was a problem hiding this comment.
was the absence causing an error?
|
Hi @taylorfturner is this stuck - or did I miss something here, anything for me to do. Thank you. |
|
oh thanks for the ping @rxm7706. oddly the mend license check isn't passing... I'd recommend an empty commit |
Done - Waiting Approval ! @taylorfturner |
If it doesn't pass the check, we can do some more research as to the cause. |
|
reopening to re-trigger checks |
Closes
#280
#340
Synced requirements between dataprofiler and synthetic-data
Rationale for choosing dataprofiler>=0.10.3 was based on trying to sync on scipy>=1.10.0
https://github.com/capitalone/DataProfiler/blob/0.10.3/requirements.txt#L13
dataprofiler 0.10.3 - increased compatibility to scipy>=1.10.0 ;
Please review and let me know if you require any changes.
Thanks & regards.