Fix column_name and null generation #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksneab7
requested review from
tazitoo,
taylorfturner,
micdavis and
danielbarcklow
taylorfturner
approved these changes
Sep 27, 2023
taylorfturner
suggested changes
Sep 27, 2023
taylorfturner
suggested changes
Sep 27, 2023
Co-authored-by: Taylor Turner <[email protected]>
ksneab7
force-pushed
the
bug_fix_for_column_header_issue
branch
from
35d055f
to
8d65506
Compare
taylorfturner
previously approved these changes
Sep 27, 2023
taylorfturner
changed the title
taylorfturner
approved these changes
Sep 27, 2023
ksneab7
commented
Sep 27, 2023
| @@ -0,0 +1,14 @@ | |||
| """Contains a random Null generator.""" | |||
There was a problem hiding this comment.
This function is used to generate fully null columns
ksneab7
commented
Sep 27, 2023
|
|
||
| col_["rng"] = self.rng | ||
| col_["num_rows"] = num_samples | ||
| if generator_name: |
There was a problem hiding this comment.
This is needed in place of the removed warning, as we account for a fully nulled column
taylorfturner
suggested changes
Sep 27, 2023
synthetic_data/generators.py
Outdated
Comment on lines
148
to
149
| else: | ||
| generator_name = "null_generator" |
There was a problem hiding this comment.
might do an elif here for readability
Comment on lines
169
to
+172
| else: | ||
| if col_["order"] is not None: | ||
| if (not generator_name == "null_generator") and col_[ | ||
| "order" | ||
| ] is not None: |
There was a problem hiding this comment.
just an else here (only way it gets is if generator_name not in the dictionary keys) and just logging.warning)
There was a problem hiding this comment.
The warning above is not needed anymore just because of the null columns now being accounted for.
ksneab7
force-pushed
the
bug_fix_for_column_header_issue
branch
from
c84793c
to
a2ab09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.