Fixes for deployement in OS #20
Conversation
ksneab7
requested review from
JGSweets,
taylorfturner,
micdavis and
tyfarnan
as code owners
terraform_deploy/metadata_db.tf
Outdated
| @@ -15,14 +29,20 @@ resource "aws_db_instance" "metadata_db" { | |||
| instance_class = var.metadata_db_defaults["instance_class"] | |||
| username = var.metadata_db_defaults["username"] | |||
| password = local.db_password | |||
| parameter_group_name = var.metadata_db_defaults["parameter_group_name"] | |||
| parameter_group_name = length(aws_db_parameter_group.metadata_db_parameter_group) == 1 ? aws_db_parameter_group.metadata_db_parameter_group[length(aws_db_parameter_group.metadata_db_parameter_group)].name: "" | |||
| """ | ||
| state = None | ||
| try: | ||
| config = Config(connect_timeout=5, retries={"max_attempts": 0}) |
There was a problem hiding this comment.
should we allow option to pass args for connect_timeout, retries, region?
There was a problem hiding this comment.
there is an issue created that abstracts out aws completely as it doesn't really belong in this file.
#22
I would imagine that includes having a config file that accounts for this as well
There was a problem hiding this comment.
We could clarify the issue to reference that these can be settings that would be adjustable in the abstracted scenario.
There was a problem hiding this comment.
Not sure if this comment is why we are not getting this PR through but this was/is discussed in the issue pertaining to it:
This should be abstracted out so that any remote deployment is enabled for the service.
| allow_aggregation = get_aws_event_rule_state(self) | ||
| if allow_aggregation is None: | ||
| return allow_aggregation | ||
| return get_aws_event_rule_state(self) == "enabled" |
There was a problem hiding this comment.
| return get_aws_event_rule_state(self) == "enabled" | |
| return allow_aggregation == "enabled" |
Co-authored-by: Michael Davis <[email protected]>
No description provided.