Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for deployement in OS #20

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Fixes for deployement in OS #20

merged 4 commits into from
Apr 4, 2023

Conversation

ksneab7
Copy link
Contributor

@ksneab7 ksneab7 commented Mar 20, 2023

No description provided.

@@ -15,14 +29,20 @@ resource "aws_db_instance" "metadata_db" {
instance_class = var.metadata_db_defaults["instance_class"]
username = var.metadata_db_defaults["username"]
password = local.db_password
parameter_group_name = var.metadata_db_defaults["parameter_group_name"]
parameter_group_name = length(aws_db_parameter_group.metadata_db_parameter_group) == 1 ? aws_db_parameter_group.metadata_db_parameter_group[length(aws_db_parameter_group.metadata_db_parameter_group)].name: ""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe indent to make more readable?

"""
state = None
try:
config = Config(connect_timeout=5, retries={"max_attempts": 0})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we allow option to pass args for connect_timeout, retries, region?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an issue created that abstracts out aws completely as it doesn't really belong in this file.
#22

I would imagine that includes having a config file that accounts for this as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could clarify the issue to reference that these can be settings that would be adjustable in the abstracted scenario.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this comment is why we are not getting this PR through but this was/is discussed in the issue pertaining to it:

This should be abstracted out so that any remote deployment is enabled for the service.

@JGSweets JGSweets enabled auto-merge (squash) March 21, 2023 14:58
JGSweets
JGSweets previously approved these changes Mar 21, 2023
allow_aggregation = get_aws_event_rule_state(self)
if allow_aggregation is None:
return allow_aggregation
return get_aws_event_rule_state(self) == "enabled"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return get_aws_event_rule_state(self) == "enabled"
return allow_aggregation == "enabled"

@JGSweets JGSweets merged commit 1d9ef6b into capitalone:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants