fix: datetime profile JSON encoding bug #1102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micdavis
previously approved these changes
Mar 1, 2024
|
merge to |
ksneab7
previously approved these changes
Mar 4, 2024
|
Change target branch to dev and I am happy with this :) |
taylorfturner
suggested changes
Mar 4, 2024
taylorfturner
dismissed stale reviews from ksneab7 and micdavis
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening this PR since latest commit wasn't being reflected.
I'm assuming this PR was also made to alleviate the bug in the test I addressed. I figure modifying the test behavior is preferable to pinning the version as the bug is introduced within the test