Numerical column stats update #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atl1502
changed the title
atl1502
force-pushed
the
numerical_column_stats_update
branch
from
e4be13f
to
5aaf2b6
Compare
ksneab7
reviewed
Feb 2, 2024
| not df_series_clean.empty | ||
| and df_series_clean.apply(pd.to_numeric, errors="coerce").dtype == "O" | ||
| ) | ||
| if self._greater_than_64_bit: |
There was a problem hiding this comment.
Good design choice here I like it
ksneab7
previously approved these changes
Feb 2, 2024
taylorfturner
added
the
New Feature
micdavis
reviewed
Feb 5, 2024
Comment on lines
1288
to
1291
| if isinstance(values, (np.ndarray, list)): | ||
| unique_value = values[0] | ||
| else: | ||
| unique_value = values.iloc[0] | ||
| unique_value = values[0] |
There was a problem hiding this comment.
Currently there is no reason for the if/else statement because they are doing the same thing no matter what the condition is.
micdavis
previously approved these changes
Feb 5, 2024
micdavis
previously approved these changes
Feb 7, 2024
Merged
| df_series = pl.from_pandas(df_series) | ||
| min_value = df_series.min() | ||
| if self.min is not None: | ||
| min_value = type(self.min)(min_value) |
There was a problem hiding this comment.
this is not intuitive what is happening here.... type(self.min)(min_value)
There was a problem hiding this comment.
This is casting min_value to the current type of self.min
There was a problem hiding this comment.
This is not needed actually updating it to remove this line
| batch_count, | ||
| batch_biased_variance, | ||
| batch_mean, | ||
| self._biased_variance = np.float64( |
There was a problem hiding this comment.
why this add np.float64(....?
| ) | ||
|
|
||
| @BaseColumnProfiler._timeit(name="skewness") | ||
| def _get_skewness( | ||
| self, | ||
| df_series: pd.Series, | ||
| df_series: pd.Series | np.ndarray, |
There was a problem hiding this comment.
this (and following) add to account for larger than 64 bit?
taylorfturner
approved these changes
Feb 12, 2024
micdavis
approved these changes
Feb 12, 2024
taylorfturner
pushed a commit
to taylorfturner/DataProfiler
that referenced
this pull request
Mar 7, 2024
* partial update to numerical_column_stats * update with full polars replacement * reduce redundant if statement * fix histogram warning * remove unneeded casting
taylorfturner
pushed a commit
to taylorfturner/DataProfiler
that referenced
this pull request
Mar 7, 2024
* partial update to numerical_column_stats * update with full polars replacement * reduce redundant if statement * fix histogram warning * remove unneeded casting
micdavis
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Staging into `main` from `dev` (#1106) * add downloads tile (#1085) * Hot fix json bug (#1105) * update * update * update version (#1107) * add polars to requirements (#1087) * add polars to requirements * Update requirements.txt Co-authored-by: Taylor Turner <[email protected]> --------- Co-authored-by: Taylor Turner <[email protected]> * update precommit env (#1088) * Numerical column stats update (#1089) * partial update to numerical_column_stats * update with full polars replacement * reduce redundant if statement * fix histogram warning * remove unneeded casting * Profiler utils update (#1092) * update profiler utils * finish updates --------- Co-authored-by: Andrew <[email protected]>
taylorfturner
pushed a commit
to taylorfturner/DataProfiler
that referenced
this pull request
Mar 22, 2024
* partial update to numerical_column_stats * update with full polars replacement * reduce redundant if statement * fix histogram warning * remove unneeded casting
taylorfturner
pushed a commit
that referenced
this pull request
Mar 22, 2024
* partial update to numerical_column_stats * update with full polars replacement * reduce redundant if statement * fix histogram warning * remove unneeded casting
abajpai15
pushed a commit
to abajpai15/DataProfiler
that referenced
this pull request
Apr 11, 2024
* partial update to numerical_column_stats * update with full polars replacement * reduce redundant if statement * fix histogram warning * remove unneeded casting
taylorfturner
pushed a commit
that referenced
this pull request
Apr 15, 2024
* partial update to numerical_column_stats * update with full polars replacement * reduce redundant if statement * fix histogram warning * remove unneeded casting
atl1502
added a commit
that referenced
this pull request
Apr 16, 2024
* partial update to numerical_column_stats * update with full polars replacement * reduce redundant if statement * fix histogram warning * remove unneeded casting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.