Make _assimilate_histogram() not use self (alternative) #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junholee6a
changed the title
|
Taking a gander at these today -- thanks for the patience, @junholee6a! |
|
Sticking with 1071 for this changed. Closing 1073 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is an alternative for PR #1071. If this is merged, then close PR #1071
Issue: #820
This is a necessary step to resolving issue #820. Previously,
_assimilate_histogram()calledselfto decide whether the given histogram contained integers or floats, and rounded the bins for histograms that only contained integers.However, that rounding seems unnecessary. Here, we remove that rounding code entirely and modify the one test that fails,
TestTextColumnProfiler.test_profile(). To make sure the test is still valid, here are its values:The data in the profile of that test is:
The old expected histogram is:
And the new expected histogram is:
