add optional manual task-level management of rvm integration #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing approach makes rvm:hook and rvm:check a prequisite for *every* task; this adds superfluous overhead to executing any tasks that don't make any use of ruby-based functionality. By adding an alternate integration approach this PR allows for enabling RVM support via manual task configuration without making any changes to the current default behavior. The 'no_hook' integration approach is (very) roughly modelled after capistrano/passenger. The "with_rvm" convenience method provides an easy wrapper around `before TASKNAME, rvm:hook` calls to enable easily adding rvm:hook support to (one or more) tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing approach makes rvm:hook and rvm:check a prequisite for
every task; this adds superfluous overhead to executing any tasks that
don't make any use of ruby-based functionality.
By adding an alternate integration approach this PR allows for enabling
RVM support via manual task configuration without making any changes to
the current default behavior.
The 'no_hook' integration approach is (very) roughly modelled after
capistrano/passenger.
The "with_rvm" convenience method provides an easy wrapper around
before TASKNAME, rvm:hookcalls to enable easily adding rvm:hooksupport to (one or more) tasks.