Merge pull request #54 from capacitor-community/develop

Develop

.all-contributorsrc

@@ -57,11 +57,6 @@
       ]
     },
     {
-      "login": "reslear",
-      "name": "reslear",
-      "avatar_url": "https://avatars.githubusercontent.com/u/12596485?v=4",
-      "profile": "https://t.me/reslear",
-      "contributions": [
       "login": "muuvmuuv",
       "name": "Marvin Heilemann",
       "avatar_url": "https://avatars.githubusercontent.com/u/11534760?v=4",
@@ -74,4 +69,4 @@
   ],
   "contributorsPerLine": 7,
   "skipCi": true
-}
+}

android/src/main/java/ch/byrds/capacitor/contacts/Contacts.java

@@ -31,7 +31,7 @@
 @CapacitorPlugin(
     name = "Contacts",
     //requestCodes is labeled as legacy in bridge
-    // requestCodes = Contacts.REQUEST_CODE,
+    requestCodes = Contacts.REQUEST_CODE,
     permissions = { @Permission(strings = { Manifest.permission.READ_CONTACTS, Manifest.permission.WRITE_CONTACTS }, alias = "contacts") }
 )
 public class Contacts extends Plugin {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@capacitor-community/contacts",
-  "version": "1.1.1",
+  "version": "1.1.3",
   "description": "Contacts Plugin for Capacitor",
   "main": "dist/plugin.cjs.js",
   "module": "dist/esm/index.js",

src/web.ts

@@ -5,23 +5,20 @@ import type { ContactsPlugin, PermissionStatus, Contact } from './definitions';
 
 export class ContactsPluginWeb extends WebPlugin implements ContactsPlugin {
   constructor() {
-    super({
-      name: 'CapContacts',
-      platforms: ['web'],
-    });
+    super();
   }
 
   async getPermissions(): Promise<PermissionStatus> {
-    throw new Error('getPermission not available');
+    throw this.unimplemented('getPermissions - Not implemented on web.');
   }
 
   async getContacts(): Promise<{ contacts: Contact[] }> {
-    throw new Error('getContacts not available');
+    throw this.unimplemented('getContacts - Not implemented on web.');
   }
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   async saveContact(_: NewContact): Promise<void> {
-    throw new Error('getContacts not available');
+    throw this.unimplemented('saveContact - Not implemented on web.');
   }
 }