Rm undocumented req.reject API usage

cap-js · Oct 9, 2024 · 74f00a0 · 74f00a0
1 parent aff200e
commit 74f00a0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 34 deletions.
diff --git a/test/resources/error-handling/i18n/messages_en.properties b/test/resources/error-handling/i18n/messages_en.properties
@@ -1,2 +1 @@
-ORDER_EXCEEDS_STOCK=The order of {0} books exceeds the stock by {1}
-ORDER_EXCEEDS_STOCK_NO_ARGS=The order of books exceeds the stock
+ORDER_EXCEEDS_STOCK=The order of {0} books exceeds the stock by {1}
diff --git a/test/resources/error-handling/srv/custom-handler-errors.js b/test/resources/error-handling/srv/custom-handler-errors.js
@@ -72,7 +72,6 @@ module.exports = srv => {
 
       if (id === 1) req.reject(400, message, args)
       if (id === 2) req.reject(code, message, args)
-      req.reject('ORDER_EXCEEDS_STOCK_NO_ARGS')
     }
   })
 }
diff --git a/test/tests/error-handling-dev.test.js b/test/tests/error-handling-dev.test.js
@@ -347,15 +347,15 @@ describe('graphql - error handling in development', () => {
             message: 'Some Custom Error Message 1',
             numericSeverity: 4,
             status: 418,
-            target: 'some_field',
+            target: 'some_field'
             // stack: expect.any(String) // doesn't work with Node 22
           },
           {
             code: 'Some-Custom-Code2',
             message: 'Some Custom Error Message 2',
             numericSeverity: 4,
             status: 500,
-            target: 'some_field',
+            target: 'some_field'
             // stack: expect.any(String) // doesn't work with Node 22
           }
         ]
@@ -452,34 +452,5 @@ describe('graphql - error handling in development', () => {
       expect(response.data).toMatchObject({ errors })
       expect(response.data.errors[0].extensions.stacktrace).not.toHaveLength(0) // Stacktrace exists and is not empty
     })
-
-    test('req.reject with custom code', async () => {
-      const query = gql`
-        mutation {
-          CustomHandlerErrorsService {
-            Orders {
-              create(input: { id: 3, quantity: 20, stock: 10 }) {
-                id
-                quantity
-                stock
-              }
-            }
-          }
-        }
-      `
-      const errors = [
-        {
-          message: 'The order of books exceeds the stock',
-          extensions: {
-            code: '500',
-            numericSeverity: 4,
-            stacktrace: expect.any(Array)
-          }
-        }
-      ]
-      const response = await POST('/graphql', { query })
-      expect(response.data).toMatchObject({ errors })
-      expect(response.data.errors[0].extensions.stacktrace).not.toHaveLength(0) // Stacktrace exists and is not empty
-    })
   })
 })