-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reject update/delete without where #676
Draft
SamuelBrucksch
wants to merge
9
commits into
main
Choose a base branch
from
reject-delete-update-all-by-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelBrucksch
force-pushed
the
reject-delete-update-all-by-default
branch
from
June 6, 2024 12:23
287c322
to
120464c
Compare
SamuelBrucksch
changed the title
reject update/delete without where
feat: reject update/delete without where
Jun 6, 2024
I'd say for singletons not needed and to-one should be excluded as it is spec compliant |
danjoa
reviewed
Sep 23, 2024
@@ -21,6 +21,14 @@ const BINARY_TYPES = { | |||
|
|||
class SQLService extends DatabaseService { | |||
init() { | |||
this.on(['UPDATE', 'DELETE'], ({ query}, next) => { | |||
const cqn = query.UPDATE ?? query.DELETE | |||
if (!cqn.where && !cqn.from?.ref?.at(-1).where && !cqn.entity?.ref?.at(-1).where) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (!cqn.where && !cqn.from?.ref?.at(-1).where && !cqn.entity?.ref?.at(-1).where) { | |
if (!cqn.where && !(cqn.from || cqn.entity)?.ref?.at(-1).where) { |
danjoa
reviewed
Sep 23, 2024
Comment on lines
+27
to
+28
const op = query.DELETE ? 'delete' : 'update' | ||
return cds.error(`Trying to ${op} all entites. Call .where(...) explicitely, to ${op} all entities.`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const op = query.DELETE ? 'delete' : 'update' | |
return cds.error(`Trying to ${op} all entites. Call .where(...) explicitely, to ${op} all entities.`) | |
return cds.error(`${query.DELETE ? 'DELETE' : 'UPDATE'} without a where clause, which would affect all entites in the table. Add where 1=1 if your really want to do so`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To discuss: