-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hana): Apply time zones when inserting timestamps and datetimes #606
base: main
Are you sure you want to change the base?
Conversation
cds.extend (compile.to.hdbtable) .with (class { |
hana/lib/drivers/base.js
Outdated
|
||
// Consider that '-' is only allowed as timezone after ':' or 'T' | ||
await prom(this._native, 'exec')(` | ||
CREATE OR REPLACE FUNCTION ISO(RAW NVARCHAR(36)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved the function to the plugin now for hdi artifacts. I think we should enrich the compile.to.sql commands for our tests that are used under the hood. the function creation should rather be part of deployment.
I was also wondering whether we should add a prefix to ensure uniqueness also for the future.
Co-authored-by: Bob den Os <[email protected]>
No description provided.