Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-929]: Adjust composer.json configuration and optimizations for performance benefits in Production and reduced complexity in development #1071

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Oct 16, 2024

Ticket(s) or GitHub Issue

Technical Description

Update composer config and installation to have the most performance impact and remove old dev/legacy references.

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

No


Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

@Orrison Orrison added Change Type | Dependencies Pull requests that update a dependency file Change Type | DevOps Changes to DevOps labels Oct 16, 2024
@Orrison Orrison self-assigned this Oct 16, 2024
@Orrison Orrison requested a review from a team as a code owner October 16, 2024 23:16
Signed-off-by: Kevin Ullyott <[email protected]>
@Orrison Orrison added the Change Type | Content or Styling Update Changes which don't affect functionality label Oct 16, 2024
Copy link

sonarcloud bot commented Oct 16, 2024

@Orrison Orrison added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit aaec0b5 Oct 17, 2024
5 checks passed
@Orrison Orrison deleted the chore/ADVAPP-929 branch October 17, 2024 17:40
jayushi-canyon pushed a commit that referenced this pull request Oct 18, 2024
…r performance benefits in Production and reduced complexity in development (#1071)

* Remove optimize-autoloader from composer.json

Signed-off-by: Kevin Ullyott <[email protected]>

* Change to --classmap-authoritative in our Dockerfile

Signed-off-by: Kevin Ullyott <[email protected]>

* Make CI --classmap-authoritative

Signed-off-by: Kevin Ullyott <[email protected]>

* Update all composer.json configs to have minimum-stability stable

Signed-off-by: Kevin Ullyott <[email protected]>

* Update php-cs-fixer

Signed-off-by: Kevin Ullyott <[email protected]>

* Generate helper files and format

Signed-off-by: Kevin Ullyott <[email protected]>

* chore: fix enforcement of copyright on all files

* composer update

Signed-off-by: Kevin Ullyott <[email protected]>

---------

Signed-off-by: Kevin Ullyott <[email protected]>
jayushi-canyon pushed a commit that referenced this pull request Oct 18, 2024
…r performance benefits in Production and reduced complexity in development (#1071)

* Remove optimize-autoloader from composer.json

Signed-off-by: Kevin Ullyott <[email protected]>

* Change to --classmap-authoritative in our Dockerfile

Signed-off-by: Kevin Ullyott <[email protected]>

* Make CI --classmap-authoritative

Signed-off-by: Kevin Ullyott <[email protected]>

* Update all composer.json configs to have minimum-stability stable

Signed-off-by: Kevin Ullyott <[email protected]>

* Update php-cs-fixer

Signed-off-by: Kevin Ullyott <[email protected]>

* Generate helper files and format

Signed-off-by: Kevin Ullyott <[email protected]>

* chore: fix enforcement of copyright on all files

* composer update

Signed-off-by: Kevin Ullyott <[email protected]>

---------

Signed-off-by: Kevin Ullyott <[email protected]>
jayushi-canyon pushed a commit that referenced this pull request Oct 18, 2024
…r performance benefits in Production and reduced complexity in development (#1071)

* Remove optimize-autoloader from composer.json

Signed-off-by: Kevin Ullyott <[email protected]>

* Change to --classmap-authoritative in our Dockerfile

Signed-off-by: Kevin Ullyott <[email protected]>

* Make CI --classmap-authoritative

Signed-off-by: Kevin Ullyott <[email protected]>

* Update all composer.json configs to have minimum-stability stable

Signed-off-by: Kevin Ullyott <[email protected]>

* Update php-cs-fixer

Signed-off-by: Kevin Ullyott <[email protected]>

* Generate helper files and format

Signed-off-by: Kevin Ullyott <[email protected]>

* chore: fix enforcement of copyright on all files

* composer update

Signed-off-by: Kevin Ullyott <[email protected]>

---------

Signed-off-by: Kevin Ullyott <[email protected]>
jayushi-canyon pushed a commit that referenced this pull request Oct 18, 2024
…r performance benefits in Production and reduced complexity in development (#1071)

* Remove optimize-autoloader from composer.json

Signed-off-by: Kevin Ullyott <[email protected]>

* Change to --classmap-authoritative in our Dockerfile

Signed-off-by: Kevin Ullyott <[email protected]>

* Make CI --classmap-authoritative

Signed-off-by: Kevin Ullyott <[email protected]>

* Update all composer.json configs to have minimum-stability stable

Signed-off-by: Kevin Ullyott <[email protected]>

* Update php-cs-fixer

Signed-off-by: Kevin Ullyott <[email protected]>

* Generate helper files and format

Signed-off-by: Kevin Ullyott <[email protected]>

* chore: fix enforcement of copyright on all files

* composer update

Signed-off-by: Kevin Ullyott <[email protected]>

---------

Signed-off-by: Kevin Ullyott <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 21, 2024
…llments, and programs (#1075)

* Create list and create page

* Complete student module

* Complete program module

* Complete enrollment module

* Create configuration page

* Create cascade delete

* Remove manageable models

* Add icons

* Remove extra lines of code

* add policies

* shift student module files

* shift program module files

* shift enrollment module files

* Solve enrollment suggestions

* Solve Program suggestions

* Make changes in migration files

* Create student segment relationship for student

* [ADVAPP-918]: Cleanup FeatureFlag: AddUrlToThemeSettingsFeature (#1054)

* [ADVAPP-918]: Cleanup FeatureFlag: AddUrlToThemeSettingsFeature

* feature flag added as it was removed

* featureflag placed into the right spot

* [ADVAPP-927]: Resolve the security issue tracked under CVE-2024-47823 (#1061)

* Specifically require a non-vulnerable version

Signed-off-by: Kevin Ullyott <[email protected]>

* Remove module lock file that is not needed and causing vuln reporting issues

Signed-off-by: Kevin Ullyott <[email protected]>

---------

Signed-off-by: Kevin Ullyott <[email protected]>

* [ADVAPP-929]: Adjust composer.json configuration and optimizations for performance benefits in Production and reduced complexity in development (#1071)

* Remove optimize-autoloader from composer.json

Signed-off-by: Kevin Ullyott <[email protected]>

* Change to --classmap-authoritative in our Dockerfile

Signed-off-by: Kevin Ullyott <[email protected]>

* Make CI --classmap-authoritative

Signed-off-by: Kevin Ullyott <[email protected]>

* Update all composer.json configs to have minimum-stability stable

Signed-off-by: Kevin Ullyott <[email protected]>

* Update php-cs-fixer

Signed-off-by: Kevin Ullyott <[email protected]>

* Generate helper files and format

Signed-off-by: Kevin Ullyott <[email protected]>

* chore: fix enforcement of copyright on all files

* composer update

Signed-off-by: Kevin Ullyott <[email protected]>

---------

Signed-off-by: Kevin Ullyott <[email protected]>

* Create list and create page

* Create configuration page

* Add icons

* [ADVAPP-918]: Cleanup FeatureFlag: AddUrlToThemeSettingsFeature (#1054)

* [ADVAPP-918]: Cleanup FeatureFlag: AddUrlToThemeSettingsFeature

* feature flag added as it was removed

* featureflag placed into the right spot

* [ADVAPP-929]: Adjust composer.json configuration and optimizations for performance benefits in Production and reduced complexity in development (#1071)

* Remove optimize-autoloader from composer.json

Signed-off-by: Kevin Ullyott <[email protected]>

* Change to --classmap-authoritative in our Dockerfile

Signed-off-by: Kevin Ullyott <[email protected]>

* Make CI --classmap-authoritative

Signed-off-by: Kevin Ullyott <[email protected]>

* Update all composer.json configs to have minimum-stability stable

Signed-off-by: Kevin Ullyott <[email protected]>

* Update php-cs-fixer

Signed-off-by: Kevin Ullyott <[email protected]>

* Generate helper files and format

Signed-off-by: Kevin Ullyott <[email protected]>

* chore: fix enforcement of copyright on all files

* composer update

Signed-off-by: Kevin Ullyott <[email protected]>

---------

Signed-off-by: Kevin Ullyott <[email protected]>

* Create list and create page

* Create configuration page

* Add icons

* Delete unwanted files

* Delete student record manager folder

* Create again since i deleted in merge conflicts

* disable view edit and delete of enrollment

* Solve merge conflicts

* chore: fix enforcement of copyright on all files

* chore: fix code style

* Update the can access check

Signed-off-by: Kevin Ullyott <[email protected]>

* Remove the save override

Signed-off-by: Kevin Ullyott <[email protected]>

* Update the enrollment policy

Signed-off-by: Kevin Ullyott <[email protected]>

* Update the ProgramPolicy

Signed-off-by: Kevin Ullyott <[email protected]>

* Final fixes for Policies

Signed-off-by: Kevin Ullyott <[email protected]>

* Delete old ManageStudentConfigurationSettings

Signed-off-by: Kevin Ullyott <[email protected]>

* Delete dupliate migration

Signed-off-by: Kevin Ullyott <[email protected]>

* Add a primary key to enrollments and restore singular actions

Signed-off-by: Kevin Ullyott <[email protected]>

* Remove custom resolving the item

Signed-off-by: Kevin Ullyott <[email protected]>

* Remove extra key parsing

Signed-off-by: Kevin Ullyott <[email protected]>

* Add an id on programs

Signed-off-by: Kevin Ullyott <[email protected]>

* chore: fix enforcement of copyright on all files

* chore: fix code style

* Fix the view button auth checks

Signed-off-by: Kevin Ullyott <[email protected]>

* chore: fix code style

* Fix rules and casting

Signed-off-by: Kevin Ullyott <[email protected]>

* FInish the Student Importer

Signed-off-by: Kevin Ullyott <[email protected]>

* Add details to Student import

Signed-off-by: Kevin Ullyott <[email protected]>

* Finish Enrollment import

Signed-off-by: Kevin Ullyott <[email protected]>

* Finish the programs importer

Signed-off-by: Kevin Ullyott <[email protected]>

* Revert bad conflict resolution

Signed-off-by: Kevin Ullyott <[email protected]>

* Fix permissions for Student Configuration manage page

Signed-off-by: Kevin Ullyott <[email protected]>

* Fix the canAny calls

Signed-off-by: Kevin Ullyott <[email protected]>

* chore: fix code style

---------

Signed-off-by: Kevin Ullyott <[email protected]>
Co-authored-by: kandarp-canyon <[email protected]>
Co-authored-by: Kevin Ullyott <[email protected]>
Co-authored-by: jayushi-canyon <[email protected]>
Co-authored-by: joelicatajr <[email protected]>
Co-authored-by: Kevin Ullyott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Type | Content or Styling Update Changes which don't affect functionality Change Type | Dependencies Pull requests that update a dependency file Change Type | DevOps Changes to DevOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants