-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADVAPP-917]: Improve the UI/UX design of the student profile page #1060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review this all with dark mode turn on. Currently styles are not reflecting the rest of the app in darkmode and therefore look off or hard to read.
I will now look into the Timeline issues while you are working on this feedback.
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/src/Livewire/ManageStudentTasks.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/src/Livewire/ManageStudentTasks.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/header/index.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/page/index.blade.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new tests for the following:
- ViewStudentTest
- This test should cover very basic tests like permission access to this page
- It should also test whether or not the premium features are shown based on the Application having them on or off
- These tests are needed to ensure we don't have leakage of ability in this change.
.../Resources/StudentResource/RelationManagers/StudentApplicationSubmissionsRelationManager.php
Outdated
Show resolved
Hide resolved
...del/src/Filament/Resources/StudentResource/RelationManagers/StudentEventsRelationManager.php
Outdated
Show resolved
Hide resolved
...ilament/Resources/StudentResource/RelationManagers/StudentFormSubmissionsRelationManager.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amit-canyon I have fixed the timeline modal so the actions now work. Please make sure the links are working on the smaller version of the timeline though.
Right now I click them and it seems to just reload the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some last few items:
- Let's change the empty state of the timeline area to say "There are no activities to show for this student."
- On the Profile information section there is a line at the very bottom. Let's not have that so that the bottom just has the curved edges.
- Finally please explore whether or not you can get all 4 of the relation mangers in the center to be the same height. If you are unable to do so before you head out for the day please let me know
Overall let me know your progress on these items before you head out for the day so I can pick up finishing anything.
I'll create a test ViewStudentTest
when you are done. More things will be added to this test in the future but I would like to start with a couple of items.
- Based on the Feature
access ensure that each premium feature relation manager is not present or present based on whether it's feature is on or off
Thank you!
…ent and other changes
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
…ager Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
d7d021c
to
87823e4
Compare
Signed-off-by: Kevin Ullyott <[email protected]>
Quality Gate passedIssues Measures |
Ticket(s) or GitHub Issue
Technical Description
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.