[ADVAPP-917]: Improve the UI/UX design of the student profile page #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orrison
requested changes
Oct 23, 2024
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/student-header-section.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/src/Livewire/ManageStudentTasks.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/src/Livewire/ManageStudentTasks.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/header/index.blade.php
Outdated
Show resolved
Hide resolved
app-modules/student-data-model/resources/views/components/page/index.blade.php
Outdated
Show resolved
Hide resolved
Orrison
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Please add a new tests for the following:
- ViewStudentTest
- This test should cover very basic tests like permission access to this page
- It should also test whether or not the premium features are shown based on the Application having them on or off
- These tests are needed to ensure we don't have leakage of ability in this change.
.../Resources/StudentResource/RelationManagers/StudentApplicationSubmissionsRelationManager.php
Outdated
Show resolved
Hide resolved
...del/src/Filament/Resources/StudentResource/RelationManagers/StudentEventsRelationManager.php
Outdated
Show resolved
Hide resolved
...ilament/Resources/StudentResource/RelationManagers/StudentFormSubmissionsRelationManager.php
Outdated
Show resolved
Hide resolved
Orrison
reviewed
Oct 28, 2024
Orrison
requested changes
Oct 28, 2024
There was a problem hiding this comment.
@amit-canyon I have fixed the timeline modal so the actions now work. Please make sure the links are working on the smaller version of the timeline though.
Right now I click them and it seems to just reload the page.
Orrison
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Some last few items:
- Let's change the empty state of the timeline area to say "There are no activities to show for this student."
- On the Profile information section there is a line at the very bottom. Let's not have that so that the bottom just has the curved edges.
- Finally please explore whether or not you can get all 4 of the relation mangers in the center to be the same height. If you are unable to do so before you head out for the day please let me know
Overall let me know your progress on these items before you head out for the day so I can pick up finishing anything.
I'll create a test ViewStudentTest when you are done. More things will be added to this test in the future but I would like to start with a couple of items.
- Based on the Feature access ensure that each premium feature relation manager is not present or present based on whether it's feature is on or off
Thank you!
…ent and other changes
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
…ager Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Signed-off-by: Kevin Ullyott <[email protected]>
Orrison
force-pushed
the
features/ADVAPP-917
branch
from
d7d021c
to
87823e4
Compare
Signed-off-by: Kevin Ullyott <[email protected]>
|
Orrison
approved these changes
Oct 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.