SV: use AmuletAllocation expiresAt for early expiry (#5743) - #6647
Open
tellary wants to merge 1 commit into
Open
SV: use AmuletAllocation expiresAt for early expiry (#5743)#6647tellary wants to merge 1 commit into
tellary wants to merge 1 commit into
Conversation
) SvDsoStore now honours the earlier `expiresAt` deadline when ingesting `AmuletAllocation` contracts, falling back to the coarser settlement `settleBefore` when it is not set. This releases locked amulet sooner. Also replace the TODO(canton-network#5743) on `AmuletTransferInstruction` with a note explaining that its `executeBefore` is already capped to `tokenStandardMaxTTL` at creation, so no separate stored expiry exists. Add store tests covering early-expired and active-with-expiresAt allocations, and a release note. Signed-off-by: Ilya Silvestrov <tellary@gmail.com>
dfordivam
assigned
dfordivam and unassigned
rautenrieth-da,
ray-roestenburg-da,
isegall-da and
martinflorian-da
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SvDsoStore now honours the earlier
expiresAtdeadline when ingestingAmuletAllocationcontracts, falling back to the coarser settlementsettleBeforewhen it is not set. This releases locked amulet sooner.Also replace the TODO(#5743) on
AmuletTransferInstructionwith a note explaining that itsexecuteBeforeis already capped totokenStandardMaxTTLat creation, so no separate stored expiry exists.Add store tests covering early-expired and active-with-expiresAt allocations, and a release note.
Fixes #5743
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines