Upload protobuf encoding of snapshot/updates to bulk storage. - #6602
Open
mrdziuban wants to merge 1 commit into
Open
Upload protobuf encoding of snapshot/updates to bulk storage.#6602mrdziuban wants to merge 1 commit into
mrdziuban wants to merge 1 commit into
Conversation
Contributor
Author
|
Note I haven't yet tackled this point from #6497
Let me know if you'd like to see those new APIs be a part of this PR, or would prefer to hold off on them. If I should include them, would it be okay to update the existing |
Fixes canton-network#6497. This updates `SingleAcsSnapshotBulkStorage.getSource` and `UpdateHistorySegmentBulkStorage.getSource` to upload both the API and protobuf encoding of the relevant data to bulk storage. After incrementing the contracts/updates count metrics, each class: - Fans out for both encodings - For each encoding, encodes and uploads the data, then increments object count metrics - Fans back in so the resulting `Source` contains the keys of all uploaded objects for both encodings This Pekko logic is handled by a new generic `MultiEncodingBulkStorageFlow`, which uses Pekko's `Broadcast` and `Merge` to handle the fan-out and fan-in behavior. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
mrdziuban
force-pushed
the
mrdziuban/dump-protobuf-encoding/6497
branch
from
July 29, 2026 17:16
7f6f10a to
2a84ec8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6497
This updates
SingleAcsSnapshotBulkStorage.getSourceandUpdateHistorySegmentBulkStorage.getSourceto upload both the API and protobuf encoding of the relevant data to bulk storage.After incrementing the contracts/updates count metrics, each class:
Sourcecontains the keys of all uploaded objects for both encodingsThis Pekko logic is handled by a new generic
MultiEncodingBulkStorageFlow, which uses Pekko'sBroadcastandMergeto handle the fan-out and fan-in behavior.Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines