SV UI: More descriptive names for Reward Config - #6578
Merged
Conversation
JYC11
changed the title
dfordivam
assigned
dfordivam and unassigned
rautenrieth-da,
ray-roestenburg-da,
isegall-da and
martinflorian-da
Contributor
Author
|
JYC11
force-pushed
the
jaeyoon/adetokunbo/cip-104-use-descriptive-names-for-reward-config
branch
from
July 28, 2026 01:58
b521c51 to
9a0635b
Compare
8 tasks
dfordivam
reviewed
Jul 28, 2026
meiersi-da
reviewed
Jul 28, 2026
meiersi-da
left a comment
meiersi-da
left a comment
Contributor
There was a problem hiding this comment.
Thanks @JYC11 . This is a nice improvement. I've added suggestions for some improved wording.
I leave the final approval to @pawelperek-da , as I'd like his OK wrt the ConfigField.tsx changes.
JYC11
force-pushed
the
jaeyoon/adetokunbo/cip-104-use-descriptive-names-for-reward-config
branch
from
July 29, 2026 02:17
9fac410 to
e06895b
Compare
meiersi-da
reviewed
Jul 29, 2026
meiersi-da
left a comment
meiersi-da
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fixes to the descriptions @JYC11 . The only thing missing then is @pawelperek-da's review.
JYC11
force-pushed
the
jaeyoon/adetokunbo/cip-104-use-descriptive-names-for-reward-config
branch
from
August 3, 2026 02:35
e06895b to
f1be273
Compare
JYC11
force-pushed
the
jaeyoon/adetokunbo/cip-104-use-descriptive-names-for-reward-config
branch
from
August 10, 2026 03:59
218150f to
0211945
Compare
JYC11
force-pushed
the
jaeyoon/adetokunbo/cip-104-use-descriptive-names-for-reward-config
branch
from
August 11, 2026 00:32
0211945 to
fc5041f
Compare
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Co-authored-by: Divam <681060+dfordivam@users.noreply.github.com> Signed-off-by: Jaeyoon Cho <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Jaeyoon Cho <jaeyoon.c@gmail.com>
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Jaeyoon Cho <jaeyoon.c@gmail.com>
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Jaeyoon Cho <jaeyoon.c@gmail.com>
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Jaeyoon Cho <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
JYC11
force-pushed
the
jaeyoon/adetokunbo/cip-104-use-descriptive-names-for-reward-config
branch
from
August 12, 2026 00:50
fc5041f to
6031286
Compare
dfordivam
deleted the
jaeyoon/adetokunbo/cip-104-use-descriptive-names-for-reward-config
branch
August 12, 2026 03:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5986
took over from #6180