Restructure wallet directory sections - #9
Merged
Conversation
- Rename Interoperability category to dApp Connectivity (CIP-103) - Rename cc_support display name to "CC support"; add two_step_cc_transfers - Rename memo_tag_support to "transfers to omnibus accounts" and move it into Token Standard (it's a CIP-0056 concern, not Interoperability) - Split validator_hosting into validator_hosting_byov/private/shared under a new Validator Hosting category, above Transaction Signing; migrate Dfns's existing true answer to validator_hosting_byov (direct carry-forward of their old self-hosted/BYOV claim, not a new claim) - Capitalize Network Relevant Features - Update TEMPLATE.yaml and proof templates to match - Fix stale cc_support/memo_tag_support proof anchors in dfns.yaml and the dummy-wallet example after the renames, plus a pre-existing broken third-party-verification anchor (thirdparty vs third-party) found while verifying
Missing 'added' values sort to the end; same-day ties break alphabetically by name for stability.
# Conflicts: # WALLET_DIRECTORY.md
- Update cc_support/memo_tag_support proof anchors and proof-file headings to match the renames (CC support; memo tag support for transfers to omnibus accounts), and move memo_tag_support into the Token Standard block in each wallet's yaml - Rename each wallet's Interoperability comment to dApp Connectivity (CIP-103) - Migrate Walley's validator_hosting: false to validator_hosting_byov, carrying forward its existing reason (direct claim match: it explicitly said BYOV is not offered) - Flag both Askardex's and Walley's remaining validator hosting questions as TODOs needing a follow-up from each wallet: Askardex's old 'supported: true' doesn't say which of BYOV/private/shared applies, and Walley's reason text is ambiguous between private and shared
GitHub tables have no CSS-based width control, so a single long key_generation_method or assets_supported value was forcing that whole column wide. Wrapping keeps every column's width fixed and grows the cell's height instead.
…labels - wallet_model/custody_model/form_factor/deployment_model values now use a capitalized first letter consistently across all wallets, the dummy-wallet example, and TEMPLATE.yaml's option-list comments - Manually wrap form_factor's and deployment_model's registry name at 40 chars with <br> (both freetext, no proof heading anywhere, so safe) - Documented in _feature_registry.yaml why this must never be done to a boolean feature that has a matching proof-file heading
davidrichards-da
requested review from
hythloda,
isegall-da,
omaiko-intellecteu,
stas-sbi,
tkatrichenko and
waynecollier-da
July 31, 2026 08:52
# Conflicts: # WALLET_DIRECTORY.md # wallets/send.yaml
hythloda
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures the Wallet Directory table for readability and fixes a few naming/organization issues, plus migrates Askardex and Walley to the updated feature registry.
Section changes
Renamed "Interoperability" → "dApp Connectivity (CIP-103)"
Renamed "Network relevant features" → "Network Relevant Features"
Renamed "CC support (transfers and holding)" → "CC support"; added a new "Two-step CC transfers" feature
Renamed "Memo tag support for transfers to exchanges" → "Memo tag support for transfers to omnibus accounts" and moved it from Interoperability into Token Standard (it's a CIP-0056 concern)
Split "Validator hosting (self-hosted / BYOV)" into three separate features — Bring-Your-Own-Validator (BYOV), Private validator, Shared validator — under a new "Validator Hosting" section, above Transaction Signing
Table formatting
Legend reformatted as one item per line instead of a single run-on sentence, and dropped the colon after "Legend"
Wallets are now ordered by date added (earliest first) instead of alphabetically
Long free-text values (e.g. key generation method, assets supported) now wrap at 30 characters instead of forcing wide columns — GitHub tables have no CSS width control, so this keeps column widths predictable
Two long Feature labels (Form factor, Deployment Model) wrapped at 40 characters for the same reason
Wallet Type option values (Retail, SaaS, Self-custodial, etc.) are now capitalized consistently across all wallets and the template
Data migration
Dfns, Askardex, and Walley's cc_support/memo_tag_support proof links updated to match the renamed headings
Dfns's and Walley's validator hosting claims carried forward to the new BYOV field where the old answer was unambiguous