Fix distance calculation for moving journey #165
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
data/src/main/java/com/canopas/yourspace/data/repository/JourneyGenerator.kt (1)
Line range hint
171-177: Consider adding data consistency validation.The accumulation logic is correctly implemented, matching the behavior when the user stops moving. However, consider adding validation to ensure data consistency between
route_distanceandroutes.val updatedJourney = lastKnownJourney.copy( to_latitude = newLocation.latitude, to_longitude = newLocation.longitude, - // Add new distance to previous distance, if you want cumulative - route_distance = (lastKnownJourney.route_distance ?: 0.0) + distance, + route_distance = when { + lastKnownJourney.routes.isEmpty() -> distance + lastKnownJourney.route_distance == null -> + // Log potential data inconsistency + distance + else -> lastKnownJourney.route_distance + distance + }, route_duration = lastKnownJourney.updated_at - lastKnownJourney.created_at,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
data/src/main/java/com/canopas/yourspace/data/repository/JourneyGenerator.kt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (2)
data/src/main/java/com/canopas/yourspace/data/repository/JourneyGenerator.kt (2)
Line range hint
1-190: Add tests for the distance accumulation logic.The implementation looks good, but please add tests to verify:
- Distance accumulation when user stops moving
- Distance accumulation during continuous movement
- Handling of null route_distance
- Edge cases with empty routes list
Would you like me to help create test cases for these scenarios?
145-145: LGTM! Verify the distance accumulation behavior.The change correctly accumulates the route distance instead of replacing it, fixing the issue of only saving the last two routes' distance. The null-safe operator ensures safe handling of initial null cases.
Let's verify the fix by checking if there are any other places in the codebase where route distance is calculated:
✅ Verification successful
Verified: Distance calculation implementation is consistent across the codebase
The route distance calculation is correctly implemented:
- Initial journey creation sets the base distance
- Subsequent updates properly accumulate the distance
- Other occurrences are just data copying operations during encryption/decryption
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for route_distance assignments to ensure consistent behavior rg -l "route_distance\s*=" | xargs rg "route_distance\s*="Length of output: 742
Script:
#!/bin/bash # Get context around the simple route_distance assignment rg "route_distance = distance," -B 5 -A 5 # View the methods containing route_distance assignments in JourneyKtx.kt ast-grep --pattern 'fun $_ { $$$ route_distance = $_ $$$ }' data/src/main/java/com/canopas/yourspace/data/service/location/JourneyKtx.ktLength of output: 1594
Script:
#!/bin/bash # Get broader context around route_distance assignments in JourneyKtx.kt rg "route_distance = route_distance" -B 5 -A 5 data/src/main/java/com/canopas/yourspace/data/service/location/JourneyKtx.ktLength of output: 916
Changelog
Bug Fixes
Summary by CodeRabbit