Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the integration test #7

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fixes the integration test #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/integration/test_sriov_net_device_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,15 @@

import logging
from pathlib import Path
import subprocess

from k8s_test_harness import harness
from k8s_test_harness.util import env_util, k8s_util

LOG = logging.getLogger(__name__)


def _clone_git_repo(location: Path, repo: str, branch: str, instance: harness.Instance):
location.mkdir()

def _clone_git_repo(location: Path, repo: str, branch: str):
clone_command = [
"git",
"clone",
Expand All @@ -25,7 +24,7 @@ def _clone_git_repo(location: Path, repo: str, branch: str, instance: harness.In
str(location.absolute()),
]

instance.exec(clone_command)
subprocess.run(clone_command, check=True)


def _deploy_sriov_ndp(temp_path: Path, instance: harness.Instance):
Expand All @@ -35,7 +34,7 @@ def _deploy_sriov_ndp(temp_path: Path, instance: harness.Instance):

clone_path = temp_path / "sriov-ndp"
repo = "https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin"
_clone_git_repo(clone_path, repo, "v3.6.2", instance)
_clone_git_repo(clone_path, repo, "v3.6.2")
deployments_path = clone_path / "deployments"

# Create a NetworkAttachmentDefinition and a deployment requiring it.
Expand Down
Loading