Changes rock base to bare #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiubelu
force-pushed
the
change-base-to-bare
branch
2 times, most recently
from
33e1b34 to
da15c94
Compare
Switching to a bare-based image will reduce the overall image size and reduces attack surface area. The image is supposed to run a script, thus we need a few packages installed. ddptool is not statically built, so it still depends on /lib and /lib64, which is why we're adding base-files. Switch the container user to root. It is supposed to have access to certain host folders through hostPath mounts, and thus, it should be able to modify them (e.g.: create /var/log/sriovdp folder). We can no longer use ensure_image_contains_paths to check if files exist in the rock images, since they are now bare-based. Instead, we can use ensure_image_contains_paths_bare, which checks the image layers instead. Because of this, we need sufficient permissions to check the /var/lib/docker folder.
claudiubelu
force-pushed
the
change-base-to-bare
branch
from
da15c94 to
569288c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to a bare-based image will reduce the overall image size and reduces attack surface area.
The image is supposed to run a script, thus we need a few packages installed.
ddptoolis not statically built, so it still depends on/liband/lib64, which is why we're addingbase-files.Switch the container user to root. It is supposed to have access to certain host folders through
hostPathmounts, and thus, it should be able to modify them (e.g.: create/var/log/sriovdpfolder).We can no longer use ensure_image_contains_paths to check if files exist in the rock images, since they are now bare-based. Instead, we can use ensure_image_contains_paths_bare, which checks the image layers instead. Because of this, we need sufficient permissions to check the
/var/lib/dockerfolder.