Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use the rustup snap to install latest stable rust #111

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ghislainbourgeois
Copy link
Collaborator

Description

This changes the way Rust and Cargo are installed for building the charm. Instead of using the deb packages available for the base, it uses the rustup snap to install the latest stable Rust and Cargo releases.

This will solve building issues for modules like pydantic that now depend on newer releases of Rust to build.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner April 12, 2024 13:03
@gruyaume
Copy link
Contributor

My feeling here was more or less "let's use what is in the latest Ubuntu". But I understand if we really want the latest pydantic we need this workaround.

@ghislainbourgeois ghislainbourgeois marked this pull request as draft April 12, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants