Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added image creation from public lxd server #378

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

felix-engelmann
Copy link
Contributor

There is an option to pull public images from existing lxd instances, similar to simplestream.

Signed-off-by: Felix Engelmann [email protected]

@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #378 into master will increase coverage by 0.12%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   96.26%   96.38%   +0.12%     
==========================================
  Files          12       12              
  Lines        1044     1051       +7     
  Branches      121      122       +1     
==========================================
+ Hits         1005     1013       +8     
+ Misses         17       16       -1     
  Partials       22       22
Impacted Files Coverage Δ
pylxd/models/image.py 98.27% <85.71%> (-0.81%) ⬇️
pylxd/models/container.py 90.25% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79a8fe...69cf484. Read the comment docs.

Signed-off-by: Felix Engelmann <[email protected]>
Copy link
Contributor

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you also update the documentation to include the new class method?

pylxd/models/image.py Outdated Show resolved Hide resolved
@ajkavanagh
Copy link
Contributor

This is great; unfortunately, I can't merge it yet, as due to an unrelated issue, it won't pass its integration tests. See #379 for more details. When that's sorted, we can rebase this, and then get it merged.

@codecov-commenter
Copy link

Codecov Report

Merging #378 (bb6eacb) into master (82a6adb) will decrease coverage by 0.83%.
The diff coverage is 85.71%.

❗ Current head bb6eacb differs from pull request most recent head 8d84ffd. Consider uploading reports for the commit 8d84ffd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   97.21%   96.38%   -0.84%     
==========================================
  Files          55       12      -43     
  Lines        4027     1051    -2976     
  Branches        0      122     +122     
==========================================
- Hits         3915     1013    -2902     
+ Misses        112       16      -96     
- Partials        0       22      +22     
Impacted Files Coverage Δ
pylxd/models/image.py 98.27% <85.71%> (-1.73%) ⬇️
pylxd/models/container.py 90.25% <0.00%> (-9.75%) ⬇️
pylxd/models/profile.py 94.59% <0.00%> (-5.41%) ⬇️
pylxd/models/operation.py 97.36% <0.00%> (-2.64%) ⬇️
pylxd/models/cluster.py 94.59% <0.00%> (-0.41%) ⬇️
pylxd/managers.py 100.00% <0.00%> (ø)
pylxd/models/_model.py 100.00% <0.00%> (ø)
pylxd/models/network.py 100.00% <0.00%> (ø)
pylxd/models/certificate.py 100.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a6adb...8d84ffd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants