Prevent refresh by revision when the snap is already on that revision #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benhoyt -- tagging for review |
benhoyt
requested changes
May 23, 2024
Style fixes from PR Co-authored-by: Ben Hoyt <[email protected]>
benhoyt
approved these changes
May 24, 2024
tonyandrewmeyer
approved these changes
May 24, 2024
Co-authored-by: Tony Meyer <[email protected]>
|
Opened #123 to track fixing the integration test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #120
snap refresh --revision=xyzcauses snapd to restart the service provided by that snap, even if the revision is already on the machine. In this limited case, we should not refresh the snap if it is already on the correct revision.