apt.py: use CalledProcessError.stderr in exceptions instead of output/stdout #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we okay with these |
benhoyt
requested changes
Dec 15, 2023
|
Oh, can we add an integration test or two to ensure stderr actually appears correctly "in real life"? |
benhoyt
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in #114 , this patch changes some select
PackageErrorexceptions to consumeCalledProcessError.stderrinstead ofCalledProcessError.output(an alias forstdout).These exceptions should now actually contain the error output of the subprocesses with non-zero exit codes.