Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default SnapClient timeout to 30 seconds #111

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Increase default SnapClient timeout to 30 seconds #111

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e91fa82
Increase default SnapClient timeout to 30 seconds
neoaggelos Sep 14, 2023
852db7e
Bump LIBPATCH to 3
neoaggelos Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/charms/operator_libs_linux/v2/snap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ def __init__(
socket_path: str = "/run/snapd.socket",
opener: Optional[urllib.request.OpenerDirector] = None,
base_url: str = "http://localhost/v2/",
timeout: float = 5.0,
timeout: float = 30.0,
):
"""Initialize a client instance.
Expand All @@ -701,7 +701,7 @@ def __init__(
opener: specifies an opener for unix socket, if unspecified a default is used
base_url: base url for making requests to the snap client. Defaults to
http://localhost/v2/
timeout: timeout in seconds to use when making requests to the API. Default is 5.0s.
timeout: timeout in seconds to use when making requests to the API. Default is 30.0s.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pity the online lib docs don't show these defaults in the SnapClient.__init__ signature so that we have to repeat them here, but oh well.

"""
if opener is None:
opener = self._get_default_opener(socket_path)
Expand Down