Apply suggestions from review comments

canonical · Jan 20, 2025 · 0f11219 · 0f11219
1 parent 52caf97
commit 0f11219
Show file tree

Hide file tree

Showing 22 changed files with 49 additions and 0 deletions.
diff --git a/connector-template/rock/rockcraft.yaml.j2 b/connector-template/rock/rockcraft.yaml.j2
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/abuseipdb_ipblacklist/rock/rockcraft.yaml b/connectors/abuseipdb_ipblacklist/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/alienvault/rock/rockcraft.yaml b/connectors/alienvault/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/cisa_kev/rock/rockcraft.yaml b/connectors/cisa_kev/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/crowdstrike/charmcraft.yaml b/connectors/crowdstrike/charmcraft.yaml
@@ -98,6 +98,10 @@ config:
       description: (optional) The base URL for the CrowdStrike APIs.
       type: string
       optional: true
+    crowdstrike-default-x-opencti-score:
+      description: (optional) crowdstrike default x opencti score.
+      type: int
+      optional: true
     crowdstrike-indicator-high-score:
       description: (optional) If any of the low score labels are found on the indicator then this value is used as a score.
       type: int

diff --git a/connectors/crowdstrike/rock/rockcraft.yaml b/connectors/crowdstrike/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/cyber_campaign/rock/rockcraft.yaml b/connectors/cyber_campaign/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/export_file_csv/rock/rockcraft.yaml b/connectors/export_file_csv/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/export_file_stix/rock/rockcraft.yaml b/connectors/export_file_stix/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/export_file_txt/rock/rockcraft.yaml b/connectors/export_file_txt/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/import_document/rock/rockcraft.yaml b/connectors/import_document/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/import_file_stix/rock/rockcraft.yaml b/connectors/import_file_stix/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/malwarebazaar/rock/rockcraft.yaml b/connectors/malwarebazaar/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/misp_feed/rock/rockcraft.yaml b/connectors/misp_feed/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/mitre/rock/rockcraft.yaml b/connectors/mitre/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/sekoia/rock/rockcraft.yaml b/connectors/sekoia/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/urlscan/rock/rockcraft.yaml b/connectors/urlscan/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/urlscan_enrichment/rock/rockcraft.yaml b/connectors/urlscan_enrichment/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/virustotal_livehunt/rock/rockcraft.yaml b/connectors/virustotal_livehunt/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/connectors/vxvault/rock/rockcraft.yaml b/connectors/vxvault/rock/rockcraft.yaml
@@ -24,6 +24,8 @@ parts:
       - python3
       - libmagic1
       - libffi8
+      - libxslt1.1
+      - libxml2
     override-build: |
       craftctl default
       mkdir -p $CRAFT_PART_INSTALL/opt

diff --git a/scripts/gen_connector_charm.py b/scripts/gen_connector_charm.py
@@ -330,6 +330,11 @@ def extract_crowdstrike_configs(doc_url: str) -> dict:
         }
     result.update(DEFAULT_CONFIG)
     del result["connector-scope"]
+    result["crowdstrike-default-x-opencti-score"] = {
+        "description": "(optional) crowdstrike default x opencti score.",
+        "type": "int",
+        "optional": True,
+    }
     return result
 
 

diff --git a/src/charm.py b/src/charm.py
@@ -115,6 +115,8 @@ def __init__(self, *args: typing.Any):
         )
         self.framework.observe(self.on.opencti_peer_relation_broken, self._cleanup_secrets)
         self.framework.observe(self.on.stop, self._cleanup_secrets)
+        self.framework.observe(self.on.opencti_connector_relation_joined, self._reconcile)
+        self.framework.observe(self.on.opencti_connector_relation_changed, self._reconcile)
 
     def _register_opensearch(self) -> OpenSearchRequires:
         """Create OpenSearchRequires instance and register related event handlers.