Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the name to set to an interface is already an altname (LP: #1994822) #292

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Check if the name to set to an interface is already an altname (LP: #1994822) #292

wants to merge 5 commits into from

Commits on Oct 26, 2022

  1. Check if the name to set to an interface is already an altname 

    This prevents an exception caused by trying to set a name that already
exists in an interface
    @drencrom
    drencrom committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    b1ba2a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Add unit test for new method 

    Also call static method using class name instead of self instance
    @drencrom
    drencrom committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    3f0d6d1 View commit details
    Browse the repository at this point in the history

  2. Replace multi line string for string concatenation 

    To comply with codestyle regulations
    @drencrom
    drencrom committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    37e9fb4 View commit details
    Browse the repository at this point in the history

  3. Change implementation of get_alt_names to use json output 

    Fix unit test to adapt to new implementation
    @drencrom
    drencrom committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    8563928 View commit details
    Browse the repository at this point in the history

  4. Add missing blank line

    @drencrom
    drencrom committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    76a8568 View commit details
    Browse the repository at this point in the history