-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Better DNS persistence solution for systemd #14589
base: main
Are you sure you want to change the base?
Conversation
Hi @simondeziel and @tomponline , I've re-submitted the PR as you asked. I've added information regarding the situation Simon has encountered, and also opened #14588 , because |
@kkovacs If the existing |
I'm not very familiar with The But of course, it's up to the LXD project how to do this. I would be most happier if resolving the |
Please sign the CLA https://ubuntu.com/legal/contributors/agreement |
Please can you also rebase as main has fixes for some linter issues that are blocking the tests. |
50cc98f
to
cd26ca4
Compare
I did!
I did :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you sign off your commits.
See https://github.com/canonical/lxd/blob/main/CONTRIBUTING.md#developer-certificate-of-origin
The CLA check is failing with
|
cd26ca4
to
878d2a5
Compare
Signed off, removed "apparently", fixed "author", rebased, pushed. Fingers crossed. :) |
DCO and CLA check are good :) |
@minaelee happy with this? |
Thank you @minaelee! It's incredible how much clearer you have made the text. Kudos! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested updates based on this conversation, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
2f8b60c
to
3c5236f
Compare
Rebase, and hopefully commits will be signed now... |
3c5236f
to
77414ee
Compare
958f6c6
to
e50e5c1
Compare
Doc tests are failing with:
Also please can you rebase. |
e50e5c1
to
a451d83
Compare
Sorry, I was away for the holiday - I've fixed the |
We've got a doc test failure:
You should wrap commands in backticks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've got a doc test failure:
@minaelee would you mind fixing up this PR if you get a chance?
…ntainers from the host machine. Co-authored-by: Minae Lee <[email protected]> Signed-off-by: KKovacs <[email protected]>
a451d83
to
a0986d9
Compare
Signed-off-by: Minae Lee <[email protected]>
28afea3
to
886be68
Compare
Thanks @minaelee for fixing it -- sorry I was AFK the past weeks. (We lazy Europeans :) ) |
No worries, and thanks for your contribution! And thanks to @simondeziel for his git assist :) |
I'm temporarily converting this to |
Thanks, it would be great to get this merged soon so it can be in the LXd 6.3 release. |
@kkovacs any update on this? Thanks |
Amended documentation with a better way to setup DNS-resolving LXD containers from the host machine.
This is a re-submit of #14572 .