lxd/image: Acquire image lock for uploaded images #14100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MggMuggins
force-pushed
the
acquire-lock-during-image-upload
branch
from
c5d9021
to
42e58e1
Compare
Attempt to reduce code duplication. This will allow me to acquire the lock in one place instead of two (next commit). Signed-off-by: Wesley Hershberger <[email protected]>
Fixes canonical#13855 This needs to happen late in the upload process because we need to verify the uploaded image's fingerprint before acquiring a lock. Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
force-pushed
the
acquire-lock-during-image-upload
branch
from
42e58e1
to
8a59f7f
Compare
tomponline
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13855
imageOperationLocks are not being taken at the start of aPOST /1.0/imagesbecause the image fingerprint can't be trusted until the file has been uploaded (see lxd/images/go). This makes it fairly easy to forget to take a lock at all.