shared/cmd: Allow a cmd asker to be created with a logger instance #13859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmougard
force-pushed
the
feat/asker-in-debug-mode
branch
from
5a463f2
to
e588b88
Compare
masnax
previously approved these changes
Aug 2, 2024
tomponline
requested changes
Aug 22, 2024
If a command asker is set with a logger instance, the question and answer (even if it is invalid) are systematically logged. This will greatly help debugability in integration test suites like in MicroCloud which have a lot of interactions in the command line. Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/asker-in-debug-mode
branch
from
e588b88
to
5c1fcef
Compare
gabrielmougard
changed the title
|
@tomponline updated |
|
@gabrielmougard linting issues need fixing |
gabrielmougard
force-pushed
the
feat/asker-in-debug-mode
branch
2 times, most recently
from
40d7144
to
80e2400
Compare
…govet)` lint error Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/asker-in-debug-mode
branch
from
80e2400
to
128f9de
Compare
tomponline
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a command asker is with a logger, the question and answer (even if it is invalid) are systematically logged to the logger destination. This will greatly help debugability in integration test suites like in MicroCloud which have a lot of interactions in the command line.