Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd/storage_pools: Don't crash on nil pool (from Incus) #13854

Closed

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Aug 1, 2024

cherry-picked from lxc/incus#359

Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 86fb1858aa4b0babacda814d1fd8408f30b008ee)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani kadinsayani marked this pull request as draft August 1, 2024 23:18
@tomponline
Copy link
Member

@kadinsayani we may not need this one as LXD has a different authorizer structure. cc @markylaing

@tomponline tomponline changed the title lxd/storage_pools: Don't crash on nil pool lxd/storage_pools: Don't crash on nil pool (from Incus) Aug 2, 2024
@tomponline
Copy link
Member

Added "(from Incus)" to PR description to help with attribution

@markylaing
Copy link
Contributor

This one isn't needed. The Authorizer doesn't implement AddStoragePool because it uses the database directly, and does not call an external openfga server.

@tomponline tomponline closed this Aug 9, 2024
@kadinsayani kadinsayani deleted the storage-pools-nil-pool-crash branch August 9, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants