Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update architectures documentation (from Incus) #13851

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Aug 1, 2024

cherry-picked from: lxc/incus#354

Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit f801ce295b93ba9e1b0f13575f9f06f1ceb62a9c)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 5bf8467f60483fc26043174606210f1cbc1f4c4e)
License: Apache-2.0
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit c01be783042396400669576527f1d1136f0a9f16)
License: Apache-2.0
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 455038265de17e9488c0b9f8a914bd8e38191775)
License: Apache-2.0
@github-actions github-actions bot added the Documentation Documentation needs updating label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Heads up @mionaalex - the "Documentation" label was applied to this issue.

@tomponline tomponline changed the title doc: Update architectures documentation doc: Update architectures documentation (from Incus) Aug 2, 2024
@tomponline
Copy link
Member

@kadinsayani added " (from Incus)" to PR description to help with attribution

@tomponline tomponline requested a review from ru-fu August 2, 2024 07:14
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes should probably be separate commits on top of the cherry-picks?

doc/.wordlist.txt Outdated Show resolved Hide resolved
doc/architectures.md Outdated Show resolved Hide resolved
@ru-fu
Copy link
Contributor

ru-fu commented Aug 5, 2024

You'll need "Loongarch" in the .custom_wordlist.txt file after all. :)

@kadinsayani
Copy link
Contributor Author

"Loongarch" is currently in the .custom_wordlist.txt file. To clarify, does it also need to be included in .wordlist.txt?

@ru-fu
Copy link
Contributor

ru-fu commented Aug 6, 2024

"Loongarch" is currently in the .custom_wordlist.txt file. To clarify, does it also need to be included in .wordlist.txt?

No, only in .custom_wordlist.txt. I didn't check - I just saw that the documentation check is read.

.custom_wordlist.txt actually has LoongArch (different capitalisation), and Google confirms that is actually correct. So it should be changed for the cherry pick.

Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@tomponline tomponline merged commit f020857 into canonical:main Aug 7, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants