build(deps): bump golang.org/x/crypto from 0.24.0 to 0.25.0

[dependabot]

Bumps golang.org/x/crypto from 0.24.0 to 0.25.0.

Commits

• 9fadb0b go.mod: update golang.org/x dependencies
• a6a393f all: bump go.mod version and drop compatibility shims
• 1c74500 ssh/test: make struct comment match struct name
• d4e7c9c ssh: fail client auth immediately on receiving disconnect message
• See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[tomponline]

Looks like stable-5.0 cannot take this change as its not compatible with Go 1.19

[tomponline]

Although most checks passed, so might just be a temporary issue...

[simondeziel]

Only the RTD fails with:

/home/docs/.asdf/installs/golang/1.19.13/packages/pkg/mod/golang.org/x/[email protected]/curve25519/curve25519.go:13:8: package crypto/ecdh is not in GOROOT (/home/docs/.asdf/installs/golang/1.19.13/go/src/crypto/ecdh)

[tomponline]

@simondeziel maybe we can increase the RTD go version?

[tomponline]

I dont get why only dir is failing to build

[simondeziel]

@simondeziel maybe we can increase the RTD go version?

That's failing when building lxc so I think we shouldn't do that. The next question is why is this not failing the CI bit doing the same thing, checking :)

[simondeziel]

@simondeziel maybe we can increase the RTD go version?

That's failing when building lxc so I think we shouldn't do that. The next question is why is this not failing the CI bit doing the same thing, checking :)

The Check compatibility with min Go version step is missing from stable-5.0, that's why.

[simondeziel]

https://github.com/canonical/lxd/actions/runs/9840770258/job/27172421728?pr=13722 has the check but it doesn't work, it only fails when actually building LXD. Only the dir tests for standalone/cluster cases fail because this is the only ones we use the GOMIN version.

# Run LXD build
+ make
CC="cc" CGO_LDFLAGS_ALLOW="(-Wl,-wrap,pthread_create)|(-Wl,-z,now)" go install -v -tags "libsqlite3"  ./...
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/curve25519/curve25519.go:13:8: package crypto/ecdh is not in GOROOT (/opt/hostedtoolcache/go/1.19.13/x64/src/crypto/ecdh)
make: *** [Makefile:30: build] Error 1
Error: Process completed with exit code 2.

[simondeziel]

It always worried me to commit to allow compiling a given LXD version with an old and unsupported Go version. This worry was confirmed by golang/go#68147 (comment) which brings good points IMHO.

stable-5.0 might not be the best place to make any change but I think we should maybe consider only supporting supported Go versions for our newer branches.

[dependabot]

Superseded by #13921.